[PATCH] testbot: Remove support for the old Step files locations.

Francois Gouget fgouget at codeweavers.com
Wed Jul 11 04:35:02 CDT 2018


It is no longer needed now that all the existing Jobs follow the new
conventions.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/Steps.pm      | 5 -----
 testbot/lib/WineTestBot/StepsTasks.pm | 5 -----
 2 files changed, 10 deletions(-)

diff --git a/testbot/lib/WineTestBot/Steps.pm b/testbot/lib/WineTestBot/Steps.pm
index 71e04471d..0159314f9 100644
--- a/testbot/lib/WineTestBot/Steps.pm
+++ b/testbot/lib/WineTestBot/Steps.pm
@@ -154,11 +154,6 @@ sub GetFullFileName($)
   return undef if (!defined $self->FileName);
 
   my ($JobId, $StepNo) = @{$self->GetMasterKey()};
-  # FIXME: Remove legacy support once no such job remains (so after
-  #        $JobPurgeDays).
-  my $LegacyPath = "$DataDir/jobs/$JobId/$StepNo/" . $self->FileName;
-  return $LegacyPath if (-f $LegacyPath);
-
   my $Path = "$DataDir/jobs/$JobId/";
   $Path .= $self->PreviousNo ."/" if ($self->PreviousNo);
   return $Path . $self->FileName;
diff --git a/testbot/lib/WineTestBot/StepsTasks.pm b/testbot/lib/WineTestBot/StepsTasks.pm
index 05854bca7..470ce4e87 100644
--- a/testbot/lib/WineTestBot/StepsTasks.pm
+++ b/testbot/lib/WineTestBot/StepsTasks.pm
@@ -47,11 +47,6 @@ sub GetFullFileName($)
   return undef if (!defined $self->FileName);
 
   my ($JobId, $_StepTaskId) = @{$self->GetMasterKey()};
-  # FIXME: Remove legacy support once no such job remains (so after
-  #        $JobPurgeDays).
-  my $LegacyPath = "$DataDir/jobs/$JobId/". $self->StepNo ."/". $self->FileName;
-  return $LegacyPath if (-f $LegacyPath);
-
   my $Path = "$DataDir/jobs/$JobId/";
   $Path .= $self->PreviousNo ."/" if ($self->PreviousNo);
   return $Path . $self->FileName;
-- 
2.18.0




More information about the wine-devel mailing list