[PATCH 4/7] winspool.drv: Add performance counters service stubs.

[Dmitry Timoshkov]

Huw Davies <huw at codeweavers.com> wrote:

> > +DWORD WINAPI PerfCollect(LPWSTR query, LPVOID *data, LPDWORD size, LPDWORD obj_count)
> > +{
> > +    FIXME("%s,%p,%p,%p: stub\n", debugstr_w(query), data, size, obj_count);
> 
> A minor thing, but as I'm commenting already: could you add spaces
> after the commas in the format string?

Personally I don't like the spaces beween args in the relay logs because
they make the log noticibly larger in size. But since this looks like a
common thing in this particular file I'll change this part.

> > -104 stub PerfClose
> > -105 stub PerfCollect
> > -106 stub PerfOpen
> > +104 stdcall PerfClose()
> > +105 stdcall PerfCollect(wstr ptr ptr ptr)
> > +106 stdcall PerfOpen(wstr)
> 
> On my Windows 7 box these are 111-3, so I suspect we can drop the
> explicit ordinals here.

I'd prefer that change go in a separate patch to avoid any potential
regressions that may cause.

-- 
Dmitry.