[PATCH] winhttp/tests: Skip the tests, when we encounter a failure

Detlef Riekenberg wine.dev at web.de
Thu Jul 12 14:04:24 CDT 2018


This avoids entering the loop and flood the result file until we reach the 120 s test timeout
I saw that twice and got 7.5MB big result files


tested:
https://testbot.winehq.org/JobDetails.pl?Key=39844


The  WININET_E_INVALID_CA failure on the win2003 testbot is unrelated:
https://test.winehq.org/data/acb879c9d2feae69e8b5b1ede28523a29aef1b89/2003_newtb-w2003std/winhttp:winhttp.html



Signed-off-by: Detlef Riekenberg <wine.dev at web.de>
---
 dlls/winhttp/tests/winhttp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c
index 46504e1b0c..c9e053fbea 100644
--- a/dlls/winhttp/tests/winhttp.c
+++ b/dlls/winhttp/tests/winhttp.c
@@ -4417,9 +4417,11 @@ static void test_chunked_read(void)
         goto done;
     }
     ok( ret, "WinHttpSendRequest failed with error %u\n", GetLastError() );
+    if (!ret) goto done;
 
     ret = WinHttpReceiveResponse( req, NULL );
     ok( ret, "WinHttpReceiveResponse failed with error %u\n", GetLastError() );
+    if (!ret) goto done;
 
     header[0] = 0;
     len = sizeof(header);
-- 
2.14.1




More information about the wine-devel mailing list