[PATCH] testbot: Remove the Patch::AffectsTests field.

Francois Gouget fgouget at codeweavers.com
Fri Jul 13 05:05:19 CDT 2018


Patches which impact Wine must be tested too so this field is unused
and no longer relevant.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/ddl/update40.sql           |  4 ++++
 testbot/ddl/winetestbot.sql        |  1 -
 testbot/doc/winetestbot-schema.dia | 23 -----------------------
 testbot/lib/WineTestBot/Patches.pm |  1 -
 4 files changed, 4 insertions(+), 25 deletions(-)
 create mode 100644 testbot/ddl/update40.sql

diff --git a/testbot/ddl/update40.sql b/testbot/ddl/update40.sql
new file mode 100644
index 000000000..8fa460665
--- /dev/null
+++ b/testbot/ddl/update40.sql
@@ -0,0 +1,4 @@
+USE winetestbot;
+
+ALTER TABLE Patches
+  DROP AffectsTests;
diff --git a/testbot/ddl/winetestbot.sql b/testbot/ddl/winetestbot.sql
index 96fcdcb22..8862c6c9d 100644
--- a/testbot/ddl/winetestbot.sql
+++ b/testbot/ddl/winetestbot.sql
@@ -68,7 +68,6 @@ CREATE TABLE Patches
   WebPatchId  INT(7)          NULL,
   Received    DATETIME        NOT NULL,
   Disposition VARCHAR(40)     NOT NULL,
-  AffectsTests ENUM('Y', 'N') NOT NULL,
   FromName    VARCHAR(40)     NULL,
   FromEMail   VARCHAR(40)     NULL,
   Subject     VARCHAR(120)    NULL,
diff --git a/testbot/doc/winetestbot-schema.dia b/testbot/doc/winetestbot-schema.dia
index d3efcb8d8..c54897a83 100644
--- a/testbot/doc/winetestbot-schema.dia
+++ b/testbot/doc/winetestbot-schema.dia
@@ -1090,29 +1090,6 @@
             <dia:string>##</dia:string>
           </dia:attribute>
         </dia:composite>
-        <dia:composite type="table_attribute">
-          <dia:attribute name="name">
-            <dia:string>#AffectsTests#</dia:string>
-          </dia:attribute>
-          <dia:attribute name="type">
-            <dia:string>#BOOL#</dia:string>
-          </dia:attribute>
-          <dia:attribute name="comment">
-            <dia:string>##</dia:string>
-          </dia:attribute>
-          <dia:attribute name="primary_key">
-            <dia:boolean val="false"/>
-          </dia:attribute>
-          <dia:attribute name="nullable">
-            <dia:boolean val="false"/>
-          </dia:attribute>
-          <dia:attribute name="unique">
-            <dia:boolean val="false"/>
-          </dia:attribute>
-          <dia:attribute name="default_value">
-            <dia:string>##</dia:string>
-          </dia:attribute>
-        </dia:composite>
         <dia:composite type="table_attribute">
           <dia:attribute name="name">
             <dia:string>#FromName#</dia:string>
diff --git a/testbot/lib/WineTestBot/Patches.pm b/testbot/lib/WineTestBot/Patches.pm
index 23b921740..f5ef431eb 100644
--- a/testbot/lib/WineTestBot/Patches.pm
+++ b/testbot/lib/WineTestBot/Patches.pm
@@ -346,7 +346,6 @@ my @PropertyDescriptors = (
   CreateBasicPropertyDescriptor("Id", "Patch id", 1, 1, "S",  7),
   CreateBasicPropertyDescriptor("WebPatchId", "Wine Web Patch id", !1, !1, "N",  7),
   CreateBasicPropertyDescriptor("Received", "Received", !1, 1, "DT", 19),
-  CreateBasicPropertyDescriptor("AffectsTests", "Affects tests", !1, 1, "B", 1),
   CreateBasicPropertyDescriptor("FromName", "Author", !1, !1, "A", 40),
   CreateBasicPropertyDescriptor("FromEMail", "Author's email address", !1, !1, "A", 40),
   CreateBasicPropertyDescriptor("Subject", "Subject", !1, !1, "A", 120),
-- 
2.18.0




More information about the wine-devel mailing list