[PATCH 2/6] regedit: Don't check if heap_xalloc() succeeded in the caller
Hugh McMaster
hugh.mcmaster at outlook.com
Mon Jul 16 07:20:45 CDT 2018
Signed-off-by: Hugh McMaster <hugh.mcmaster at outlook.com>
---
programs/regedit/edit.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/programs/regedit/edit.c b/programs/regedit/edit.c
index 3e5b9dd6cb..00dcbec398 100644
--- a/programs/regedit/edit.c
+++ b/programs/regedit/edit.c
@@ -157,14 +157,9 @@ static INT_PTR CALLBACK bin_modify_dlgproc(HWND hwndDlg, UINT uMsg, WPARAM wPara
cbData = SendDlgItemMessageW(hwndDlg, IDC_VALUE_DATA, HEM_GETDATA, 0, 0);
pData = heap_xalloc(cbData);
- if (pData)
- {
- SendDlgItemMessageW(hwndDlg, IDC_VALUE_DATA, HEM_GETDATA, (WPARAM)cbData, (LPARAM)pData);
- lRet = RegSetValueExW(params->hKey, params->lpszValueName, 0, REG_BINARY, pData, cbData);
- heap_free(pData);
- }
- else
- lRet = ERROR_OUTOFMEMORY;
+ SendDlgItemMessageW(hwndDlg, IDC_VALUE_DATA, HEM_GETDATA, (WPARAM)cbData, (LPARAM)pData);
+ lRet = RegSetValueExW(params->hKey, params->lpszValueName, 0, REG_BINARY, pData, cbData);
+ heap_free(pData);
if (lRet == ERROR_SUCCESS)
EndDialog(hwndDlg, 1);
--
2.18.0
More information about the wine-devel
mailing list