[PATCH 1/6] dmusic: Sync up the dmobject.[ch] files
Michael Stefaniuc
mstefani at winehq.org
Mon Jul 16 13:43:25 CDT 2018
On 07/16/2018 08:30 AM, Zebediah Figura wrote:
> On 15/07/18 21:08, Michael Stefaniuc wrote:
>> Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
>> ---
>> dlls/dmband/dmobject.c | 212 +++++++++++++++++++++++++++++++++++++++++++++++
>> dlls/dmband/dmobject.h | 53 ++++++++++++
>> dlls/dmcompos/dmobject.c | 212 +++++++++++++++++++++++++++++++++++++++++++++++
>> dlls/dmcompos/dmobject.h | 53 ++++++++++++
>> dlls/dmloader/dmobject.c | 212 +++++++++++++++++++++++++++++++++++++++++++++++
>> dlls/dmloader/dmobject.h | 53 ++++++++++++
>> dlls/dmscript/dmobject.c | 212 +++++++++++++++++++++++++++++++++++++++++++++++
>> dlls/dmscript/dmobject.h | 53 ++++++++++++
>> dlls/dmstyle/dmobject.c | 212 +++++++++++++++++++++++++++++++++++++++++++++++
>> dlls/dmstyle/dmobject.h | 53 ++++++++++++
>> dlls/dmusic/dmobject.c | 212 +++++++++++++++++++++++++++++++++++++++++++++++
>> dlls/dmusic/dmobject.h | 53 ++++++++++++
>> dlls/dswave/dmobject.c | 212 +++++++++++++++++++++++++++++++++++++++++++++++
>> dlls/dswave/dmobject.h | 53 ++++++++++++
>> 14 files changed, 1855 insertions(+)
>>
>
> I haven't actually read through this patch in detail, so I'm not
> immediately sure if this proposal would make sense, but it looks like
> there's at least some code duplication going on here across DLLs. Would
> it make sense to have a common import library for dmusic?
Those files are identical after the patch is applied, as they should be.
Alexandre wanted those files duplicated for now. I just keep adding code
to it until he changes his mind ;)
bye
michael
More information about the wine-devel
mailing list