[PATCH 04/11] shell32: _SHCreateSymbolicLinks() don't fallback to '$HOME/My Documents'

Rob Walker bob.mt.wya at gmail.com
Mon Jul 16 17:46:58 CDT 2018


Wineprefix User Profile media directories:

  '%USERPROFILE%\\My Music'
  '%USERPROFILE%\\My Pictures'
  '%USERPROFILE%\\My Videos'

use '$HOME/My Documents' as a fallback symlink target path.
Remove this code path, as it serves no logical purpose.

Signed-off-by: Rob Walker <bob.mt.wya at gmail.com>
---
 dlls/shell32/shellpath.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c
index b223bf5212..0e2ee2e263 100644
--- a/dlls/shell32/shellpath.c
+++ b/dlls/shell32/shellpath.c
@@ -4508,12 +4508,11 @@ static void _SHCreateSymbolicLinks(void)
                                             && S_ISDIR(statFolder.st_mode);
         }
 
-        /* Use the same target as '%USERPROFILE%\\My Documents' (fallback). */
-        if (!target_ok)
-            strcpy(szMyStuffTarget, szPersonalTarget);
-
-        remove(pszMyStuff);
-        symlink(szMyStuffTarget, pszMyStuff);
+        if (target_ok)
+        {
+            remove(pszMyStuff);
+            symlink(szMyStuffTarget, pszMyStuff);
+        }
         heap_free(pszMyStuff);
     }
 
-- 
2.18.0




More information about the wine-devel mailing list