[PATCH 1/2] winevulkan: Expose driver vkGetInstanceProcAddr via winevulkan exports.

Józef Kucia joseph.kucia at gmail.com
Wed Jul 25 14:35:38 CDT 2018


2018-07-24 14:03 GMT+02:00 Jacek Caban <jacek at codeweavers.com>:
> +void *vkGetInstanceProcAddrWINE(VkInstance instance, const char *name)

Generally, Vulkan ICD should avoid potential clashes with Vulkan
symbols. In this case, the name clash is very unlikely, but I think we
should avoid exporting vk* symbols. Other exported functions are
prefixed with wine_, but wine_vkGetInstanceProcAddrWINE() might be not
an ideal name. I am not sure if I have better name suggestions.
Perhaps, host_vkGetInstanceProcAddr(), native_vkGetInstanceProcAddr()
or native_vkGetInstanceProcAddrWINE().

It is also a bit unfortunate that winelib apps will have to link
directly to winevulkan, but going through
vulkan-1.vkGetInstanceProcAddr() to get vkGetInstanceProcAddrWINE() is
ugly as well.



More information about the wine-devel mailing list