[PATCH 1/2] d3dcompiler_43/tests: Load d3dcompiler_43.dll dynamically.

Matteo Bruni matteo.mystral at gmail.com
Tue Jul 31 08:07:23 CDT 2018


2018-07-19 14:36 GMT+02:00 Jacek Caban <jacek at codeweavers.com>:
> Signed-off-by: Jacek Caban <jacek at codeweavers.com>
> ---
>
> My motivation for this patch is the later patch.
>
> Another nice thing about this is that we could easily run tests on
> multiple d3dcompiler versions. For example, some tests currently fail if
> they are ran with d3dcompiler_47. We could just load different DLL
> versions in a loop and run tests multiple times.

The idea makes a lot of sense to me but I'm not sure that handling it
in a loop in d3dcompiler_43 would be the best solution. I might be
biased by the fact that I have tried to do something similar for d3dx9
tests but via PARENTSRC, though :P

A couple of pretty unimportant notes WRT the actual patch:

> +static pD3DPreprocess ppD3DPreprocess;

Pretty ugly but apparently unavoidable. Oh well.

> +static typeof(D3DCreateBlob) *pD3DCreateBlob;

Not 100% sure that's okay in Wine. It should be though.



More information about the wine-devel mailing list