[PATCH] testbot: Log errors that happen when updating a Job's status.
Francois Gouget
fgouget at codeweavers.com
Tue Jun 5 03:52:34 CDT 2018
Such errors are important as they can prevent the Jobs from ever being
marked as completed. So trace them.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
This helps diagnose issues where the database schema and the TestBot's
ORM database model are out of sync.
testbot/lib/WineTestBot/Jobs.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm
index b1ffd3e48..13a389586 100644
--- a/testbot/lib/WineTestBot/Jobs.pm
+++ b/testbot/lib/WineTestBot/Jobs.pm
@@ -243,7 +243,12 @@ sub UpdateStatus($)
{
$self->Ended(time);
}
- $self->Save();
+ my ($ErrProperty, $ErrMessage) = $self->Save();
+ if (defined $ErrMessage)
+ {
+ require WineTestBot::Log;
+ WineTestBot::Log::LogMsg("Could not update job status: $ErrMessage\n");
+ }
last;
}
}
--
2.17.0
More information about the wine-devel
mailing list