[PATCH 1/3] schedsvc: Add a sanity check when loading a .job file.

Dmitry Timoshkov dmitry at baikal.ru
Fri Jun 8 02:43:47 CDT 2018


There was no problem with this patchset, however I had a file in the c:\windows\tasks
directory (dump_job.exe) that was leading to a crash in the job file loading code,
this patch fixes it.

Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
---
 dlls/schedsvc/atsvc.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dlls/schedsvc/atsvc.c b/dlls/schedsvc/atsvc.c
index 91ef3edca0..597df34f2a 100644
--- a/dlls/schedsvc/atsvc.c
+++ b/dlls/schedsvc/atsvc.c
@@ -394,6 +394,12 @@ static BOOL load_job_data(const char *data, DWORD size, struct job_t *info)
     TRACE("file_version %04x\n", fixed->file_version);
     TRACE("uuid %s\n", wine_dbgstr_guid(&fixed->uuid));
 
+    if (fixed->file_version != 0x0001)
+    {
+        TRACE("invalid file version\n");
+        return FALSE;
+    }
+
     TRACE("name_size_offset %04x\n", fixed->name_size_offset);
     TRACE("trigger_offset %04x\n", fixed->trigger_offset);
     TRACE("error_retry_count %u\n", fixed->error_retry_count);
-- 
2.16.3




More information about the wine-devel mailing list