[PATCH] gdiplus: Check return value of SelectClipPath in brush_fill_path().

[Vincent Povirk]

It looks like we also encountered this case in get_path_hrgn. Maybe we
shouldn't call brush_fill_pixels if the path is empty? If we're going
to ignore errors, I think we should at least check GetLastError() to
make sure it's one we expect.

On Fri, Jun 15, 2018 at 4:04 AM, Zhiyi Zhang <zzhang at codeweavers.com> wrote:
> For Crossover bug 16126.
>
> When GraphicPath is empty, filling path with gdi32 will
> result in a DC with empty path. When SelectClipPath() is
> called with such a DC, it will fail because it requires
> a closed path in DC. Thus further operation should be canceled.
>
> Signed-off-by: Zhiyi Zhang <zzhang at codeweavers.com>
> ---
>  dlls/gdiplus/graphics.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c
> index 76aabe74bf..2a95d686fa 100644
> --- a/dlls/gdiplus/graphics.c
> +++ b/dlls/gdiplus/graphics.c
> @@ -1052,6 +1052,7 @@ static BOOL brush_can_fill_path(GpBrush *brush, BOOL is_fill)
>
>  static void brush_fill_path(GpGraphics *graphics, GpBrush* brush)
>  {
> +    BOOL success;
>      switch (brush->bt)
>      {
>      case BrushTypeSolidColor:
> @@ -1064,8 +1065,8 @@ static void brush_fill_path(GpGraphics *graphics, GpBrush* brush)
>              RECT rc;
>              /* partially transparent fill */
>
> -            SelectClipPath(graphics->hdc, RGN_AND);
> -            if (GetClipBox(graphics->hdc, &rc) != NULLREGION)
> +            success = SelectClipPath(graphics->hdc, RGN_AND);
> +            if (success && GetClipBox(graphics->hdc, &rc) != NULLREGION)
>              {
>                  HDC hdc = CreateCompatibleDC(NULL);
>
> --
> 2.17.1
>
>
>