[PATCH] testbot: Simplify a loop in PatchUtils::GetPatchImpact().

Francois Gouget fgouget at codeweavers.com
Tue Jun 19 19:30:35 CDT 2018


Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/PatchUtils.pm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm
index ec609d987..6eb8e3cd8 100644
--- a/testbot/lib/WineTestBot/PatchUtils.pm
+++ b/testbot/lib/WineTestBot/PatchUtils.pm
@@ -227,10 +227,8 @@ sub GetPatchImpact($;$$)
 
   $Impacts->{ModuleCount} = 0;
   $Impacts->{UnitCount} = 0;
-  foreach my $Module (keys %{$Impacts->{Tests}})
+  foreach my $TestInfo (values %{$Impacts->{Tests}})
   {
-    my $TestInfo = $Impacts->{Tests}->{$Module};
-
     # For each module, identify modifications to non-C files and helper dlls
     my $AllUnits;
     foreach my $File (keys %{$TestInfo->{Files}})
-- 
2.17.1




More information about the wine-devel mailing list