[PATCH 5/7] testbot/WineSendLog: Use LogUtils to identify errors in the log files.

Francois Gouget fgouget at codeweavers.com
Tue Jun 26 06:29:55 CDT 2018


GetLogLineCategory()'s error detection is much more complete and this
avoids code duplication.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/bin/WineSendLog.pl | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl
index 2f097796e..33978095e 100755
--- a/testbot/bin/WineSendLog.pl
+++ b/testbot/bin/WineSendLog.pl
@@ -45,6 +45,7 @@ use Algorithm::Diff;
 use WineTestBot::Config;
 use WineTestBot::Jobs;
 use WineTestBot::Log;
+use WineTestBot::LogUtils;
 use WineTestBot::StepsTasks;
 
 
@@ -290,8 +291,8 @@ EOF
         {
           $CurrentDll = $1;
         }
-        if ($Line =~ m/: Test failed: / || $Line =~ m/ done \(258\)/ ||
-            $Line =~ m/: unhandled exception [0-9a-fA-F]{8} at /)
+        my $Category = GetLogLineCategory($Line);
+        if ($Category eq "error")
         {
           if ($PrintedDll ne $CurrentDll)
           {
-- 
2.18.0




More information about the wine-devel mailing list