[PATCH] testbot/WineRunTask: Better detect standard Wine tests.

Francois Gouget fgouget at codeweavers.com
Tue Jun 26 08:07:43 CDT 2018


It's better to take the step dependencies into account and to verify
that the previous step was dealing with a Wine patch.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/bin/WineRunTask.pl | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/testbot/bin/WineRunTask.pl b/testbot/bin/WineRunTask.pl
index ff8aab9f4..9fa263eea 100755
--- a/testbot/bin/WineRunTask.pl
+++ b/testbot/bin/WineRunTask.pl
@@ -441,9 +441,10 @@ if ($Step->Type eq "single")
   }
   $Script .= "> $RptFileName\r\n";
 
-  # If StepNo is 1 then the user gave us an executable. Then there is no
-  # telling if it's going to follow the Wine test standards.
-  $IsWineTest = ($StepNo != 1);
+  # If the user gave us an executable there is no telling
+  # if it is going going to follow the Wine test standards.
+  $IsWineTest = (defined $Step->PreviousNo and
+                 $Job->Steps->GetItem($Step->PreviousNo)->FileType eq "patchdlls");
 }
 elsif ($Step->Type eq "suite")
 {
-- 
2.18.0




More information about the wine-devel mailing list