[PATCH] d3dx9: Improve argument validation in CloneEffect()

[Matteo Bruni]

2018-03-02 7:28 GMT+01:00 Nikolay Sivov <bunglehead at gmail.com>:
> On 3/2/2018 3:31 AM, Matteo Bruni wrote:
>> 2018-03-01 13:14 GMT+01:00 Nikolay Sivov <nsivov at codeweavers.com>:
>>
>>> diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c
>>> index 1900f3eac1..28dcf47cd3 100644
>>> --- a/dlls/d3dx9_36/tests/effect.c
>>> +++ b/dlls/d3dx9_36/tests/effect.c
>>> @@ -7294,6 +7294,91 @@ static void test_effect_null_shader(void)
>>>      DestroyWindow(window);
>>>  }
>>>
>>> +static void test_effect_clone(IDirect3DDevice9 *device)
>>
>> Could you make the test create its own device instead, like the last
>> two tests added to the file?
>
> Does it mean other tests should not reuse it either?

Ideally they shouldn't, yeah.