[PATCH v3] msvcrt: Compile but show an error if Bessel functions aren't available
Piotr Caban
piotr at codeweavers.com
Fri Mar 2 10:27:11 CST 2018
Hi Alex,
On 03/02/18 17:21, Alex Henrie wrote:
> @@ -1472,12 +1497,17 @@ double CDECL MSVCRT__yn(int order, double num)
> {
> double retval;
> if (!isfinite(num)) *MSVCRT__errno() = MSVCRT_EDOM;
> +#ifdef HAVE_YN
> retval = yn(order,num);
> if (MSVCRT__fpclass(retval) == MSVCRT__FPCLASS_NINF)
> {
> *MSVCRT__errno() = MSVCRT_EDOM;
> retval = sqrt(-1);
> }
> +#else
> + FIXME( "not implemented\n" );
> + retval = 0;
> +#endif
> return retval;
> }
The patch looks mostly good for me. Could you please also remove the
spaces after '(' and before ')' in FIXME to match surrounding code
style? While you're at it, could you please also remove sqrt(-1) calls
on error paths and just return NAN?
Thanks,
Piotr
More information about the wine-devel
mailing list