[PATCH] testbot: Simplify updating a Step's status.

Francois Gouget fgouget at codeweavers.com
Thu Mar 8 10:48:56 CST 2018


Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/Steps.pm | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/testbot/lib/WineTestBot/Steps.pm b/testbot/lib/WineTestBot/Steps.pm
index 45ec6359f..40dfc0a44 100644
--- a/testbot/lib/WineTestBot/Steps.pm
+++ b/testbot/lib/WineTestBot/Steps.pm
@@ -146,12 +146,7 @@ sub UpdateStatus($$)
   return $Status if ($Status ne "queued" && $Status ne "running");
 
   my %Has;
-  my $Tasks = $self->Tasks;
-  foreach my $TaskKey (@{$Tasks->GetKeys()})
-  {
-    my $Task = $Tasks->GetItem($TaskKey);
-    $Has{$Task->UpdateStatus($Skip)} = 1;
-  }
+  map { $Has{$_->UpdateStatus($Skip)} = 1 } (@{$self->Tasks->GetItems()});
 
   # Inherit the tasks most significant status.
   # Note that one or more tasks may have been requeued during the cleanup phase
-- 
2.16.1




More information about the wine-devel mailing list