[PATCH 2/2 v4] kernel32: Support MOVEFILE_WRITE_THROUGH / CopyFileExW progress

[Tom Watson]

On Thu, Mar 8, 2018 at 10:35 PM, Zebediah Figura <z.figura12 at gmail.com>
wrote:

> On 04/03/18 23:04, Tom Watson wrote:
>
> A few comments here:
>

Thanks for your comments, being new here I cut and pasted an earlier
example and used it as a base, I'll take them on board and see about
resubmitting.


> ...
>


> +/*
> + * Code temporarily disabled to pass the automated tests
> + * as the code to hanlde PROGRESS_STOP/PROGRESS_CANCEL needs
> + * to be installed on the vms
> + */
>
> MoveFileWithProgress() is supported since Windows XP; I would be
> surprised if those flags are not implemented on native Windows.
>
> Rather, I suspect that your tests make assumptions about native
> implementation of CopyFile based on Wine's implementation. It's not
> necessarily true that Windows copies files in blocks of 65536 bytes. Did
> you check, when testing, that your callback ever actually ran?
>

I did test on testbot, at the time I did not realise they VMs there are
actual systems I thought they were running the Wine dlls, you educated me
to this earlier in the week, makes more sense now. The 65536 comes from
Wine's kernel32/path.c,  https://source.winehq.org/git/wine.
git/blob/HEAD:/dlls/kernel32/path.c#l1159 so I used it to test locally,
they tests failed on testbot as it uses native win32. The test needs to be
removed/rethought as none of the VMs actually call the progress function
when copying a 128Mb file.

Thanks again for your comments.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20180309/d0df73df/attachment.html>