[PATCH 2/7] wsdapi: Add stub implementation of IWSDiscoveryPublisher_PublishEx.
huw at codeweavers.com
Mon Mar 12 07:46:43 CDT 2018
On Mon, Mar 12, 2018 at 12:08:40PM +0000, Owen Rudge wrote:
> On 12/03/2018 10:23, Huw Davies wrote:
> >You should call PublishEx through the COM macro
> >IWSDiscoveryPublish_PublishEx() than the directly through the function
> >name. That way you wouldn't need to re-order the functions.
> Thanks, I'll do that.
> > There are lots of uses of CamelCase variables in this series which
> > we generally dislike.
> Mostly this is to maintain consistency with the rest of the DLL, which I've
> generally written using camelCase, I suppose out of personal preference. If
> it's likely to be an issue I can change it though.
> > Also, you're pushing the limits on line length in places.
> Thanks, I'll look at that; lots of very long parameter names in these
> functions unfortunately!
Well, looking at send_hello_message(), "ullMessageNumber" could go to
"msg_num" for example...
More information about the wine-devel