[PATCH 6/7] wmp: Stub IWMPNetwork get download/buffering progress

[Zebediah Figura]

On 12/03/18 23:34, Anton Romanov wrote:
> Signed-off-by: Anton Romanov <theli.ua at gmail.com>
> ---
>  dlls/wmp/player.c      | 22 ++++++++++++++++++----
>  dlls/wmp/tests/media.c | 13 +++++++++++++
>  2 files changed, 31 insertions(+), 4 deletions(-)
> 
> diff --git a/dlls/wmp/player.c b/dlls/wmp/player.c
> index d3c67a3820..ddee6667f4 100644
> --- a/dlls/wmp/player.c
> +++ b/dlls/wmp/player.c
> @@ -1130,8 +1130,15 @@ static HRESULT WINAPI WMPNetwork_get_bufferingCount(IWMPNetwork *iface, LONG *pl
>  static HRESULT WINAPI WMPNetwork_get_bufferingProgress(IWMPNetwork *iface, LONG *plBufferingProgress)
>  {
>      WindowsMediaPlayer *This = impl_from_IWMPNetwork(iface);
> -    FIXME("(%p)->(%p)\n", This, plBufferingProgress);
> -    return E_NOTIMPL;
> +    TRACE("(%p)->(%p)\n", This, plBufferingProgress);
> +    if (!This->pFilterGraph) {
> +        return S_FALSE;
> +    }
> +    /* Ideally we would use IAMOpenProgress but we don't have it in wine (yet) */
> +    FIXME("stub: Returning buffering progress 100\n");
> +    *plBufferingProgress = 100;
> +
> +    return S_OK;

Note that not all sources support IAMOpenProgress anyway—in particular
the async file reader doesn't. Which is to say that this behaviour is
not necessarily wrong.