mpr: Return correct error code for non network paths and REMOTE_NAME_INFO_LEVEL in WNetGetUniversalName.
aeikum at codeweavers.com
Wed Mar 14 09:27:23 CDT 2018
On Wed, Mar 14, 2018 at 11:03:25AM +0100, Alexandre Julliard wrote:
> Dmitry Timoshkov <dmitry at baikal.ru> writes:
> > Zebediah Figura <z.figura12 at gmail.com> wrote:
> >> >> From: Michael Müller <michael at fds-team.de>
> >> >>
> >> >> Signed-off-by: Michael Müller <michael at fds-team.de>
> >> >> Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
> >> >
> >> > If I recall correctly the rules you can't add a sign-off for somebody
> >> > else without an explicit permission from that person.
> >> The sign-off wasn't added; it was on the original patch.
> > Still, it's you who is sending this patch, and you need to provide only your
> > own sign-off, since the original author no longer takes any responsibility
> > for this piece of code.
> If the patch is not changed, preserving the original sign-off is the
> right thing to do.
I thought Signed-off-by meant something like, "I agree to help debug
this if something goes wrong." It seems wrong to make that statement
to wine-devel on someone else's behalf. If I put a sign-off and send
it to wine-staging that means something different to me than if I send
it to wine-devel.
My understanding was the same as Dmitry's. If the original author
wants to sign-off on the patch, they should do it themselves. This
also makes the history a little more clear. A patch without a sign-off
from the author means it was submitted by someone else.
More information about the wine-devel