[PATCH 1/2] dmime/tests: Fix an IStream use after free and a leak

Michael Stefaniuc mstefani at winehq.org
Wed Mar 14 18:09:32 CDT 2018


Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
---
 dlls/dmime/tests/dmime.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/dmime/tests/dmime.c b/dlls/dmime/tests/dmime.c
index d259e41ed4..b0db27accb 100644
--- a/dlls/dmime/tests/dmime.c
+++ b/dlls/dmime/tests/dmime.c
@@ -779,7 +779,6 @@ static void test_parsedescriptor(void)
                 desc.dwValidData);
         ok(IsEqualGUID(&desc.guidClass, forms[i].clsid), "Got class guid %s, expected CLSID_%s\n",
                 wine_dbgstr_guid(&desc.guidClass), forms[i].class);
-        IStream_Release(stream);
 
         /* NULL pointers */
         memset(&desc, 0, sizeof(desc));
@@ -793,6 +792,7 @@ static void test_parsedescriptor(void)
             ok(hr == E_POINTER, "ParseDescriptor failed: %08x, expected E_POINTER\n", hr);
         hr = IDirectMusicObject_ParseDescriptor(dmo, NULL, NULL);
         ok(hr == E_POINTER, "ParseDescriptor failed: %08x, expected E_POINTER\n", hr);
+        IStream_Release(stream);
 
         /* Wrong form */
         empty[1] = DMUS_FOURCC_CONTAINER_FORM;
@@ -806,6 +806,7 @@ static void test_parsedescriptor(void)
         else
             ok(hr == E_FAIL, "ParseDescriptor failed: %08x, expected E_FAIL\n", hr);
         ok(!desc.dwValidData, "Got valid data %#x, expected 0\n", desc.dwValidData);
+        IStream_Release(stream);
 
         /* All desc chunks */
         alldesc[1] = forms[i].form;
-- 
2.14.3




More information about the wine-devel mailing list