[PATCH 4/5] wined3d: Reject managed/scratch textures with dynamic usage in texture_init().
Henri Verbeet
hverbeet at codeweavers.com
Thu Mar 15 03:08:41 CDT 2018
For consistency with volumetexture_init().
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
---
dlls/wined3d/texture.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/dlls/wined3d/texture.c b/dlls/wined3d/texture.c
index e5a83ce7cba..e1f02a5f15b 100644
--- a/dlls/wined3d/texture.c
+++ b/dlls/wined3d/texture.c
@@ -2198,8 +2198,14 @@ static HRESULT texture_init(struct wined3d_texture *texture, const struct wined3
return WINED3DERR_INVALIDCALL;
}
- if (desc->usage & WINED3DUSAGE_DYNAMIC && wined3d_resource_access_is_managed(desc->access))
- FIXME("Trying to create a managed texture with dynamic usage.\n");
+ if (desc->usage & WINED3DUSAGE_DYNAMIC && (wined3d_resource_access_is_managed(desc->access)
+ || desc->usage & WINED3DUSAGE_SCRATCH))
+ {
+ WARN("Attempted to create a dynamic texture with access %s and usage %s.\n",
+ wined3d_debug_resource_access(desc->access), debug_d3dusage(desc->usage));
+ return WINED3DERR_INVALIDCALL;
+ }
+
if (!(desc->usage & (WINED3DUSAGE_DYNAMIC | WINED3DUSAGE_RENDERTARGET | WINED3DUSAGE_DEPTHSTENCIL))
&& (flags & WINED3D_TEXTURE_CREATE_MAPPABLE))
WARN("Creating a mappable texture that doesn't specify dynamic usage.\n");
--
2.11.0
More information about the wine-devel
mailing list