[PATCH 10/10] wined3d: Don't attach render targets on clears when unnecessary.

Matteo Bruni matteo.mystral at gmail.com
Thu Mar 15 13:13:32 CDT 2018


2018-03-15 14:34 GMT+01:00 Henri Verbeet <hverbeet at gmail.com>:
> On 14 March 2018 at 22:23, Matteo Bruni <mbruni at codeweavers.com> wrote:
>> Otherwise we'd limit the cleared area to the size of the render target.
>>
>> Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
>> ---
>>  dlls/d3d9/tests/visual.c | 46 ++++++++++++++++++++++++----------------------
>>  dlls/wined3d/cs.c        |  5 ++++-
>>  2 files changed, 28 insertions(+), 23 deletions(-)
>>
> This fails here on Linux, Intel SKL:
>
>     visual.c:23653: Test failed: Expected color 0x00000000 at (520,
> 320), got 0x0000ff00.

It turns out this test also depends on not clamping the viewport to
the render target size (and shows that I didn't retest this patch on
its own...)

I guess I'm going to focus on those patches sooner rather than later.
IIRC last time I got stuck on various test failures on multiple
drivers, hopefully coming back after a while will help...



More information about the wine-devel mailing list