[PATCH] dmstyle/tests: Relax style descriptor test with nothing loaded
alexhenrie24 at gmail.com
Thu Mar 15 23:40:39 CDT 2018
Missatge de Michael Stefaniuc <mstefani at winehq.org> del dia dj., 15 de març
2018 a les 13:40:
> On 03/15/2018 06:11 AM, Alex Henrie wrote:
> > Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
> > ---
> > This test has been failing on the Windows 7 testbot since February 26,
> > likely because of a Windows update.
> Heh, that's when I added that test:
> git log 9ae8b8c00f2c dlls/dmstyle/
> I noticed the issue two days later and tried to reproduce it with
> TestBot job 36301 (already deleted on the testbot). I couldn't!
> Here's are reruns with just a whitespace change:
> Consistently not reproducible when run manually.
> Consistently reproducible when run as part of the daily run but *only*
> on newtb-w7pro64-32: The returned data is not random, always an extra
> DMUS_OBJ_VERSION that shouldn't be there.
> I've compared the dll version and it is on all the exact same dmstyle
> That's why I asked back then Francois:
> [23:37:06] <puk> fgouget_: Tag: newtb-w7pro64-32
> [23:37:14] <puk> fgouget_: which box is that?
> [23:37:37] <puk> w7pro64 (32 bit) ?
> [23:38:04] <puk> because I don't see test failures when running the
> tests manually on the WTB
> [23:38:17] <puk> newtb-w7pro64-32 is the only one to show it
> [23:59:35] <fgouget_> puk: it's a test VM, I think you can ignore it as
> I will take it down soon
> [23:59:52] <fgouget_> set as in for testing the TestBot, not for testing
> [23:59:56] <fgouget_> s/set/test/
> So I'm ignoring that issue as it will go away.
Understood, thanks for the explanation. If setting DMUS_OBJ_VERSION is not
necessarily wrong, it might be a good idea to take the patch anyway. At the
very least, the patch improves the failure message to match what was
actually tested. But I defer to the sole guru of DirectMusic ;-)
More information about the wine-devel