[PATCH] windowscodecs: Implement WICCreateBitmapFromSection.

[Hans Leidekker]

On Thu, 2018-03-15 at 23:00 +0800, Dmitry Timoshkov wrote:
> Hans Leidekker <hans at codeweavers.com> wrote:
> 
> > On Thu, 2018-03-15 at 22:40 +0800, Dmitry Timoshkov wrote:
> > > Hans Leidekker <hans at codeweavers.com> wrote:
> > > 
> > > > > +    buffer = MapViewOfFile(section, access, 0, offset, 0);
> > > > > +    if (!buffer) return HRESULT_FROM_WIN32(GetLastError());
> > > > 
> > > > MapViewOfFile wants a multiple of the allocation granularity for the
> > > > offset. Does WICCreateBitmapFromSectionEx have the same constraint?
> > > 
> > > I would be very much surprised if it doesn't, a passed in section
> > > handle implies using MapViewOfFile to access the bitmap bits.
> > 
> > It could also map at the base and store the offset.
> 
> At the moment I'm not well enough prepared to write a test case, but
> feel free to write one. I'd still assume based on syntax similarity
> of MapViewOfFile and WICCreateBitmapFromSection that the latter is
> modelled around the former one.

How about this? I'm including a modified version of your implementation
that passes the test.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wincodecs.diff
Type: text/x-patch
Size: 12926 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20180316/87faf267/attachment-0001.bin>