[PATCH] windowscodecs: Implement WICCreateBitmapFromSection.
dmitry at baikal.ru
Fri Mar 16 10:37:11 CDT 2018
Hans Leidekker <hans at codeweavers.com> wrote:
> > > > > > + buffer = MapViewOfFile(section, access, 0, offset, 0);
> > > > > > + if (!buffer) return HRESULT_FROM_WIN32(GetLastError());
> > > > >
> > > > > MapViewOfFile wants a multiple of the allocation granularity for the
> > > > > offset. Does WICCreateBitmapFromSectionEx have the same constraint?
> > > >
> > > > I would be very much surprised if it doesn't, a passed in section
> > > > handle implies using MapViewOfFile to access the bitmap bits.
> > >
> > > It could also map at the base and store the offset.
> > At the moment I'm not well enough prepared to write a test case, but
> > feel free to write one. I'd still assume based on syntax similarity
> > of MapViewOfFile and WICCreateBitmapFromSection that the latter is
> > modelled around the former one.
> How about this? I'm including a modified version of your implementation
> that passes the test.
Thanks for creating a test, the patch looks good to me, feel free to
send it for inclusion.
More information about the wine-devel