[PATCH 07/10] d3d8: Forbid setting a viewport larger than the render target.

Henri Verbeet hverbeet at gmail.com
Wed Mar 21 06:10:00 CDT 2018


On 20 March 2018 at 23:37, Matteo Bruni <mbruni at codeweavers.com> wrote:
> +    if (viewport->Width > rt_desc.width || viewport->X + viewport->Width > rt_desc.width
> +            || viewport->Height > rt_desc.height || viewport->Y + viewport->Height > rt_desc.height)
> +    {
> +        WARN("Invalid viewport, returning D3DERR_INVALIDCALL.\n");
> +        wined3d_mutex_unlock();
> +        return D3DERR_INVALIDCALL;
> +    }
So suppose you have e.g. a 640x480 render target, and I try to set
{~319u, ~239u, 640, 480, 0.0f, 1.0f} as viewport. Do we really want
that to succeed?



More information about the wine-devel mailing list