[PATCH 5/6] bcrypt: Avoid crash in tests when compiling without gnutls support.

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Wed Mar 21 22:01:12 CDT 2018


From: Sebastian Lackner <sebastian at fds-team.de>

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
---
 dlls/bcrypt/bcrypt_main.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/dlls/bcrypt/bcrypt_main.c b/dlls/bcrypt/bcrypt_main.c
index 68bee84..c219c77 100644
--- a/dlls/bcrypt/bcrypt_main.c
+++ b/dlls/bcrypt/bcrypt_main.c
@@ -1313,12 +1313,19 @@ NTSTATUS WINAPI BCryptGenerateSymmetricKey( BCRYPT_ALG_HANDLE algorithm, BCRYPT_
     if (!alg || alg->hdr.magic != MAGIC_ALG) return STATUS_INVALID_HANDLE;
     if (object) FIXME( "ignoring object buffer\n" );
 
-    if (!(key = heap_alloc( sizeof(*key) ))) return STATUS_NO_MEMORY;
+
+    if (!(key = heap_alloc( sizeof(*key) )))
+    {
+        *handle = NULL;
+        return STATUS_NO_MEMORY;
+    }
+
     key->hdr.magic = MAGIC_KEY;
 
     if ((status = key_init( key, alg, secret, secret_len )))
     {
         heap_free( key );
+        *handle = NULL;
         return status;
     }
 
@@ -1401,11 +1408,15 @@ NTSTATUS WINAPI BCryptDuplicateKey( BCRYPT_KEY_HANDLE handle, BCRYPT_KEY_HANDLE
     if (!key_orig || key_orig->hdr.magic != MAGIC_KEY) return STATUS_INVALID_HANDLE;
     if (!handle_copy) return STATUS_INVALID_PARAMETER;
     if (!(key_copy = HeapAlloc( GetProcessHeap(), 0, sizeof(*key_copy) )))
+    {
+        *handle_copy = NULL;
         return STATUS_NO_MEMORY;
+    }
 
     if ((status = key_duplicate( key_orig, key_copy )))
     {
         HeapFree( GetProcessHeap(), 0, key_copy );
+        *handle_copy = NULL;
         return status;
     }
 
-- 
1.9.1




More information about the wine-devel mailing list