[PATCH 09/10] ddraw: Reset wined3d viewport on SetRenderTarget().

Henri Verbeet hverbeet at gmail.com
Fri Mar 23 09:29:19 CDT 2018


On 22 March 2018 at 21:43, Matteo Bruni <mbruni at codeweavers.com> wrote:
> Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
> ---
> Generally the viewport is explicitly set again immediately after the
> SetRenderTarget() so you wouldn't notice the difference. The ddraw7
> test_viewport() does a Clear() before that though and, without this
> patch, it crashes in surface_cpu_blt_colour_fill() when switching from
> the 1280x960 to the 320x240 RT.
>
> I guess another option is to fix this in wined3d (instead OR in
> addition to this).
>
>  dlls/ddraw/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
This causes test failures here:

    ../../../../../src/wine-git/tools/runtest -q -P wine -T ../../..
-M ddraw.dll -p ddraw_test.exe.so d3d && touch d3d.ok
    d3d.c:2554: Test failed: vp.dwX is 0, expected 10
    d3d.c:2555: Test failed: vp.dwY is 0, expected 10
    d3d.c:2556: Test failed: vp.dwWidth is 64, expected 246
    d3d.c:2557: Test failed: vp.dwHeight is 64, expected 246
    d3d.c:2558: Test failed: vp.dvMinZ is 0.000000, expected 0.25
    d3d.c:2559: Test failed: vp.dvMaxZ is 1.000000, expected 0.75
    d3d.c:2582: Test failed: vp.dwWidth is 256, expected 64
    d3d.c:2583: Test failed: vp.dwHeight is 256, expected 64
    d3d.c:2595: Test failed: vp.dwWidth is 256, expected 64
    d3d.c:2596: Test failed: vp.dwHeight is 256, expected 64
    Makefile:193: recipe for target 'd3d.ok' failed
    make: *** [d3d.ok] Error 10



More information about the wine-devel mailing list