[PATCH 2/2] Fixed wrc gives parse error if resource nameID has quoted & Updated parse.l file

Zebediah Figura z.figura12 at gmail.com
Sat Mar 24 07:51:34 CDT 2018


On 24/03/18 05:19, Adeniyi Mayokun wrote:
> From e40c908b95aff31a5527abbd0690cc61f5f50bd4 Mon Sep 17 00:00:00 2001
> From: Adeniyi Mayokun <adeniyimayokun17 at gmail.com
> <mailto:adeniyimayokun17 at gmail.com>>
> Date: Sat, 24 Mar 2018 11:07:17 +0100
> Subject: [PATCH 2/2] Fixed wrc gives parse error if resource nameID has
> quoted
>  & Updated parse.l file
>  
>  Signed-off-by: Adeniyi Mayokun <adeniyimayokun17 at gmail.com
> <mailto:adeniyimayokun17 at gmail.com>>
> 
> ---
>  tools/wrc/parser.l | 102
> +++++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 99 insertions(+), 3 deletions(-)

Hello Adeniyi,

This patch was originally submitted by Artur Świgoń:

https://www.winehq.org/pipermail/wine-patches/2017-April/160397.html

As has been said before, you must give proper attribution when sending
patches, even if you make your own changes. Moreover, your changes
remove some indentation, and the first line breaks a macro (the usage of
both variables on one line is intentional). And in any case, as was
posted to wine-devel, this is probably not the right way to go about
solving this problem:

https://www.winehq.org/pipermail/wine-devel/2017-April/117313.html
https://www.winehq.org/pipermail/wine-devel/2017-May/117780.html

ἔρρωσο,
Zeb



More information about the wine-devel mailing list