[PATCH] testbot/web: Tweak ItemPage to save the Item directly.

Francois Gouget fgouget at codeweavers.com
Sun Mar 25 22:21:05 CDT 2018


This avoids depending on whether Items retrieved with 
Collection::GetItem() are stored in the Collection or not.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/ObjectModel/CGI/ItemPage.pm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm
index 4086a9385..b44e5b2d3 100644
--- a/testbot/lib/ObjectModel/CGI/ItemPage.pm
+++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm
@@ -137,6 +137,16 @@ sub SaveProperty($$$)
   return 1;
 }
 
+sub Save($)
+{
+  my ($self) = @_;
+
+  return !1 if (!$self->SaveProperties());
+
+  ($self->{ErrField}, $self->{ErrMessage}) = $self->{Item}->Save();
+  return ! defined($self->{ErrMessage});
+}
+
 sub OnAction($$)
 {
   my ($self, $Action) = @_;
-- 
2.16.2



More information about the wine-devel mailing list