[PATCH] explorer.c: Test for explorer.exe (try 3)
Alex Henrie
alexhenrie24 at gmail.com
Mon Mar 26 00:17:16 CDT 2018
On Fri, Mar 23, 2018 at 11:16 PM Carlos Vega García <carlosvegagc at gmail.com>
wrote:
> Signed-off-by: Carlos Vega García <carlosvegagc at gmail.com>
> Makefile.in: Makefile for explorer.exe tests (try 3)
> Signed-off-by: Carlos Vega García <carlosvegagc at gmail.com>
> Makefile.in: Makefile for explorer.exe tests (try 3)
> Signed-off-by: Carlos Vega García <carlosvegagc at gmail.com>
One Signed-off-by line is enough, and you can just get rid of the comment
about Makefile.in.
> + /*I use the character 92 = '\' because if you write the character
the gcc
> + * compiler misunderstand it*/
You can (and should) write '\\'.
You'll also need to resolve the test failures on various versions of
Windows: https://testbot.winehq.org/JobDetails.pl?Key=37113
Finally, please check the spelling and grammar of your patch. There are
mistakes in nearly every comment.
-Alex
More information about the wine-devel
mailing list