[PATCH 4/5] vulkan-1: Implement thunks for Vulkan Core functions.

[Józef Kucia]

On Wed, Mar 28, 2018 at 2:09 AM, Roderick Colenbrander
<thunderbird2k at gmail.com> wrote:
> On Tue, Mar 27, 2018 at 3:51 PM, Józef Kucia <joseph.kucia at gmail.com> wrote:
>> I wonder if we can simplify our Vulkan loader further. We could
>> potentially export all core Vulkan functions from winevulkan.dll with
>> the "wine_" prefix. The Vulkan loader documentation allows exporting
>> Vulkan functions from ICD under different names. It would allow us to
>> simply forward most of the functions directly to winevulkan.dll (even
>> in the spec file). The proposed solution would make our vulkan-1.dll
>> really minimal and simple, and would also avoid the race condition
>> mentioned in the comment below. Thoughts?
>
> I have no problems with the spec approach. Completely forgot about
> that method. The only thing we would lose out on would be debug traces
> for loader thunks, but I don't think we care much about those. Not
> sure which method I prefer most...

I don't have a strong preference for either method, but debug traces
in the loader thunks aren't necessary.