[PATCH v5 1/6] wmp: Implement playback via quartz

Jacek Caban jacek at codeweavers.com
Wed Mar 28 09:39:30 CDT 2018


Hi Anton,

On 03/28/2018 06:00 AM, Anton Romanov wrote:
> +    if (!This->filter_graph) {
> +        return NS_S_WMPCORE_COMMAND_NOT_AVAILABLE;
> +    }
> +    if (This->media_control) {
> +        hres = IMediaControl_Stop(This->media_control);
> +        IMediaControl_Release(This->media_control);
> +    }
> +    if (!This->filter_graph) {

This doesn't look right, did you mean if (This->filter_graph)? Note that
you return earlier if this is NULL, do you probably don't need that check.

> +        IGraphBuilder_Release(This->filter_graph);
> +    }


Thanks,

Jacek




More information about the wine-devel mailing list