[PATCH v7 4/6] wmp: Add seeking and duration

[Zebediah Figura]

On 29/03/18 05:10, Alistair Leslie-Hughes wrote:
> Hi Anton,
> 
> This is more of general thing with this patch set.
> 
> I would like to see more errors tested.
> 
> 
> On 29/03/18 02:31, Anton Romanov wrote:
>> Signed-off-by: Anton Romanov <theli.ua at gmail.com>
>> ---
>>
>>      SetEvent(This->stop_event);
>>      WaitForSingleObject(This->event_thread, INFINITE);
>> @@ -1492,15 +1518,33 @@ static HRESULT WINAPI WMPControls_fastReverse(IWMPControls *iface)
>>  static HRESULT WINAPI WMPControls_get_currentPosition(IWMPControls *iface, DOUBLE *pdCurrentPosition)
> What happens when an NULL value is passed in?
> 
>>  static HRESULT WINAPI WMPControls_put_currentPosition(IWMPControls *iface, DOUBLE dCurrentPosition)
>>  {
>>
> What happens when an negative value is passed in?
> 

I wouldn't be surprised if the answer is "the same thing that happens
when a negative value is passed into IMediaSeeking_SetPositions()". That
function (and quartz in general...) could certainly use some more tests
as well.