[PATCH] usp10: Don't increment variable both in the loop header and body (clang) (try 2)

Aric Stewart aric at codeweavers.com
Thu Mar 29 11:26:48 CDT 2018


I do not believe there is anything wrong with this. So if it make clang be quite it should be fine.

Signed-off-by: Aric Stewart <aric at codeweavers.com>

On 3/28/18 12:52 PM, André Hentschel wrote:
> Signed-off-by: André Hentschel <nerv at dawncrow.de>
> ---
>   dlls/usp10/shape.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/dlls/usp10/shape.c b/dlls/usp10/shape.c
> index 4031386..3827000 100644
> --- a/dlls/usp10/shape.c
> +++ b/dlls/usp10/shape.c
> @@ -1696,7 +1696,7 @@ static void ComposeConsonants(HDC hdc, WCHAR *pwOutChars, INT *pcChars, const Co
>       int offset = 0;
>       int cWalk;
>   
> -    for (cWalk = 0; cWalk < *pcChars; cWalk++)
> +    for (cWalk = 0; cWalk < *pcChars; cWalk += 2)
>       {
>           for (i = 0; consonants[i].output!= 0x0; i++)
>           {
> @@ -1721,7 +1721,6 @@ static void ComposeConsonants(HDC hdc, WCHAR *pwOutChars, INT *pcChars, const Co
>                   break;
>               }
>           }
> -        cWalk++;
>       }
>   }
>   
> 



More information about the wine-devel mailing list