[PATCH 1/4] wusa: create temp directories for installer

Vijay Kiran Kamuju infyquest at gmail.com
Thu Mar 29 11:59:38 CDT 2018


Hi Alexander,

I will check with Alistair & Zebediah from wine-staging on how to go
about writing tests for this and splitting this patch series from
staging.

Hi Alistair/Zebediah,

Can you help me on this.

Thanks,
Vijay

On Thu, Mar 29, 2018 at 6:06 PM, Alexandre Julliard <julliard at winehq.org> wrote:
> Vijay Kiran Kamuju <infyquest at gmail.com> writes:
>
>> From: Michael Müller <michael at fds-team.de>
>>
>> Signed-off-by: Vijay Kiran Kamuju <infyquest at gmail.com>
>> ---
>>  programs/wusa/main.c | 171 +++++++++++++++++++++++++++++++++++++++++++++++++--
>>  1 file changed, 166 insertions(+), 5 deletions(-)
>
> This is still an awful lot of code, and the way it's split doesn't seem
> to make much sense. I'd suggest to start by writing some tests.
>
> --
> Alexandre Julliard
> julliard at winehq.org



More information about the wine-devel mailing list