[PATCH] msvcrt: Try SNAME when matching locale.
Piotr Caban
piotr.caban at gmail.com
Tue May 1 05:03:51 CDT 2018
Hi Daniel,
On 04/30/18 22:53, Daniel Lehman wrote:
> + ret = setlocale(LC_ALL, "en-GB");
> + ok(ret != NULL || broken (ret == NULL), "ret == NULL\n");
> + if(ret)
> + ok(!strcmp(ret, "English_United Kingdom.1252")
> + || broken(!strcmp(ret, "English_United States.1252")) /* XP & 2003 */,
> + "ret = %s\n", ret);
As far as I can see all of the tests you are adding are failing with
newer versions of msvcrt (e.g. on testbot ret != NULL only on XP and
2003 machines). Do you have a machine that returns "English_United
Kingdom.1252" in this case? What version of msvcrt.dll does it have?
Are there any newer versions of Windows that are passing your tests (not
returning NULL and falling into broken condition)? What application
depends on that behavior? As long as there's no application depending on
it I prefer wine to behave the same as newer versions of the dll.
Thanks,
Piotr
More information about the wine-devel
mailing list