[PATCH 2/5 v2] riched20/tests: Rewrite tests for ITextServices_TxGetNaturalSize().

Jactry Zeng jactry92 at gmail.com
Wed May 23 03:43:58 CDT 2018


Hi Huw,

Thanks for review.

Huw Davies <huw at codeweavers.com> 于2018年5月23日周三 下午4:34写道:
> While the original test isn't great, it does at least compare the
> returned size to font metrics.  You'll need to figure out the
> algorithm rather than just hardcoding a (very large) range.

That range looks large is because that the Japanese Windows
testbot has a different font. And That minimum is for the Japanese testbot.
Can I just skip these tests in Japanese testbot and supplement
some more tests for comparing the returned size to font metrics?

> Huw.




--
Regards,
Jactry Zeng



More information about the wine-devel mailing list