[PATCH 3/6] dwrite: Skip failing font metrics test for Goha

Lucian Poston lucianposton at pm.me
Sat May 26 08:42:51 CDT 2018


On Sat, May 26, 2018 at 06:05:00AM -0700, Nikolay Sivov wrote:
> How do I test this?I installed this font by manually extracting it from 
> Arch's xorg-fonts-misc 1.0.3-5, but I don't see any failures.

The failure arises only when you apply the subsequent patches (patch 4/6 I
believe), which cause that test map characters to the Goha font from the
system fonts. So you could apply the whoel patch series except this one to see
the failure.

If it doesn't fail with arch's versoin, perhaps mine is corrupted, and it is a
non-issue. I isolated this change so that in such a case, you can just drop
this patch.

I uploaded the one from my system, in case you wanted to risk trying it.
https://transfer.sh/br8lo/GohaTibebZemen.otf

> The fact that it's not working on Windows is not very important, we 
> still should try to make it usable.

How would you define the test's expected values if we can't get them from
windows?




More information about the wine-devel mailing list