[PATCH] testbot: Fix handling of test unit deletion + helper dll patch

Francois Gouget fgouget at codeweavers.com
Mon May 28 17:42:49 CDT 2018


Take into account deleted test units when getting the full test unit
list.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/PatchUtils.pm | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm
index 74599ba30..62784874c 100644
--- a/testbot/lib/WineTestBot/PatchUtils.pm
+++ b/testbot/lib/WineTestBot/PatchUtils.pm
@@ -199,12 +199,7 @@ sub GetPatchImpact($)
       # Helper dlls are not test units
       next if (exists $TestInfo->{Files}->{"$Base.spec"});
 
-      if ($AllUnits)
-      {
-        # All test units are impacted indirectly and must be rerun
-        $TestInfo->{Units}->{$Base} = 1;
-      }
-      elsif ($TestInfo->{Files}->{$File} and
+      if (($AllUnits or $TestInfo->{Files}->{$File}) and
              $TestInfo->{Files}->{$File} ne "rm")
       {
         # Only new/modified test units are impacted
-- 
2.17.0



More information about the wine-devel mailing list