[PATCH 2/2] testbot/build: Fix handling of directory addition / removal.

Francois Gouget fgouget at codeweavers.com
Wed May 30 01:05:35 CDT 2018


When a directory is added or removed we must re-run make_makefiles.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/PatchUtils.pm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm
index 6c72e1639..a466df359 100644
--- a/testbot/lib/WineTestBot/PatchUtils.pm
+++ b/testbot/lib/WineTestBot/PatchUtils.pm
@@ -87,7 +87,16 @@ sub _AddTest($$$)
   }
 
   # Assume makefile modifications may break the build but not the tests
-  return if ($File eq "Makefile.in" or $Impacts->{NoUnits});
+  if ($File eq "Makefile.in")
+  {
+    if ($Change eq "new" or $Change eq "rm")
+    {
+      # This adds / removes a directory
+      $Impacts->{Makefiles} = 1;
+    }
+    return;
+  }
+  return if ($Impacts->{NoUnits});
 
   if (!$Tests->{$Module}->{Files})
   {
-- 
2.17.0



More information about the wine-devel mailing list