[PATCH] testbot: Fix error checking on a Steps::Save() call.

Francois Gouget fgouget at codeweavers.com
Wed May 30 08:27:43 CDT 2018


Collection::Save() returns three values, unlike Item::Save() which only
returns two!

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/Jobs.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm
index 6be271ba3..ef0d98e24 100644
--- a/testbot/lib/WineTestBot/Jobs.pm
+++ b/testbot/lib/WineTestBot/Jobs.pm
@@ -98,7 +98,7 @@ sub OnDelete($)
 
   my $Steps = $self->Steps;
   map { $_->PreviousNo(undef) } @{$Steps->GetItems()};
-  my ($_ErrProperty, $ErrMessage) = $Steps->Save();
+  my ($_ErrKey, $_ErrProperty, $ErrMessage) = $Steps->Save();
 
   return $ErrMessage || $self->SUPER::OnDelete();
 }
-- 
2.17.0



More information about the wine-devel mailing list