[PATCH] testbot: Fix the "Set doesn't affect tests" message.

Francois Gouget fgouget at codeweavers.com
Thu May 31 03:04:32 CDT 2018


There is no need to rerun the tests for part N of a patch set if it
does not impact the tests: the results would be the same as those
already obtained from the combined part 1 .. part N patch.
So adjust the message to better convey this.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/Patches.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/Patches.pm b/testbot/lib/WineTestBot/Patches.pm
index 71d735b08..d5be1b355 100644
--- a/testbot/lib/WineTestBot/Patches.pm
+++ b/testbot/lib/WineTestBot/Patches.pm
@@ -137,7 +137,7 @@ sub Submit($$$)
   my $Impacts = GetPatchImpact("$DataDir/patches/" . $self->Id, undef, $PastImpacts);
   if (!$Impacts->{UnitCount})
   {
-    $self->Disposition(($IsSet ? "Set" : "Patch") .
+    $self->Disposition(($IsSet ? "Part" : "Patch") .
                        " doesn't affect tests");
     return undef;
   }
-- 
2.17.0



More information about the wine-devel mailing list