[PATCH] testbot/web: Move some Submit.pl variables closer to the usage.

Francois Gouget fgouget at codeweavers.com
Thu May 31 04:00:33 CDT 2018


Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/web/Submit.pl | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl
index 6451745a9..2b4e5ec14 100644
--- a/testbot/web/Submit.pl
+++ b/testbot/web/Submit.pl
@@ -509,15 +509,12 @@ sub DetermineFileType($$)
 {
   my ($self, $FileName) = @_;
 
-  my $ErrMessage = undef;
-  my $FileType = "unknown";
-  my $DllBaseName = undef;
-  my $TestUnit = undef;
   if (! sysopen(FH, $FileName, O_RDONLY))
   {
     return ("Unable to open $FileName", "unknown", undef, undef);
   }
 
+  my $FileType = "unknown";
   my $Buffer;
   if (sysread(FH, $Buffer, 0x40))
   {
@@ -563,6 +560,7 @@ sub DetermineFileType($$)
 
   close FH;
 
+  my ($ErrMessage, $DllBaseName, $TestUnit);
   if ($FileType eq "unknown")
   {
     my $Impacts = GetPatchImpact($FileName);
-- 
2.17.0




More information about the wine-devel mailing list