[PATCH v4 1/4] shell32/autocomplete: Implement a cache and sort the enumerated strings for proper behavior

[Huw Davies]

On Thu, Nov 01, 2018 at 02:23:50PM +0200, Gabriel Ivăncescu wrote:
> > So you moved this to a helper as I suggested and then moved it back in
> > the next patch??  You could add a BOOL flag to hide_listbox that
> > performs the reset if it's set.
> 
> That said there's still a problem with this: since the reset doesn't
> exist before this patch, should I add a normal hide_listbox (with
> "broken" behavior that always resets) in this patch, and then in the
> next patch convert it to hide_listbox with a BOOL flag? Is that
> alright, or every patch needs to be correct by itself?
> 
> If that's not acceptable (i.e. "temporary" slightly broken behavior),
> I don't know how else to split it up; prior to this patch, there's no
> "reset" at all. So every hide_listbox call-site would have to be
> changed in this patch, which makes it larger... and I wanted to avoid
> that.

Adding the extra param to hide_listbox in this patch will make the
patch bigger, but it's a simple change so it's easy to review.

Huw.