[PATCH] wshom: Split the command line before passing it to ShellExecuteEx.

[Hans Leidekker]

On Sat, 2018-11-03 at 21:21 +0100, Francois Gouget wrote:
> On Fri, 2 Nov 2018, Hans Leidekker wrote:
> 
> > Signed-off-by: Hans Leidekker <hans at codeweavers.com>
> > ---
> >  dlls/wshom.ocx/shell.c       | 34 ++++++++++++++++++++++++--
> >  dlls/wshom.ocx/tests/wshom.c | 57 +++++++++++++++++++++++++++++++++++++++++++-
> >  2 files changed, 88 insertions(+), 3 deletions(-)
> > 
> > diff --git a/dlls/wshom.ocx/shell.c b/dlls/wshom.ocx/shell.c
> > index 1aa353a17a..ca4f7ff899 100644
> > --- a/dlls/wshom.ocx/shell.c
> > +++ b/dlls/wshom.ocx/shell.c
> > @@ -1218,12 +1218,37 @@ static inline BOOL is_optional_argument(const VARIANT *arg)
> >      return V_VT(arg) == VT_ERROR && V_ERROR(arg) == DISP_E_PARAMNOTFOUND;
> >  }
> >  
> > +static WCHAR *split_command( BSTR cmd, WCHAR **params )
> 
> Should split_command() be more like build_argv() (from 
> kernel32/process.c)?
> 
> (Wondering about handling of backslashes, duplicate double quotes, escaped 
> double quotes, etc.)

Yes, it will probably look like that eventually. I stopped at
supporting quoted and unquoted strings, which is sufficient for
Magic the Gathering Arena.