[PATCH resend 1/8] comctl32/listbox: Make SetCount fail if LBS_NODATA is not set

Gabriel Ivăncescu gabrielopcode at gmail.com
Tue Nov 6 05:58:04 CST 2018


On Tue, Nov 6, 2018 at 1:48 PM Alexandre Julliard <julliard at winehq.org> wrote:
>
> Both are acceptable, but if it's easy to add todo_wine, it's better to
> send the test first. This way it's clear which test failures the patch
> is fixing. In your case it seems that adding todos would be trivial, so
> that's what you should do.
>
> --
> Alexandre Julliard
> julliard at winehq.org

Well in this case the patches are small and the tests follow them and
prove the behavior of the respective patch. (I already sent them,
hopefully it's not such a big deal)

Just for future reference: If I were to use todo on larger tests (that
have their own function), I would use the todo_wine before calling the
function? Placing them on each 'ok' statement will require a lot of
todos otherwise.



More information about the wine-devel mailing list